Skip to content

Update resources and add must-gather - #83644

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
lpiwowar:lpiwowar/resources-fix
Aug 21, 2026
Merged

Update resources and add must-gather#83644
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
lpiwowar:lpiwowar/resources-fix

Conversation

@lpiwowar

@lpiwowar lpiwowar commented Aug 19, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

Updates the openstack-k8s-operators/lightspeed-operator CI configuration. OpenShift 4.20 jobs now collect extra data and a must-gather after tests. The kuttl-test step now has higher CPU and memory allocations.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: f8a83a95-b9d9-4ae4-816a-cb85d49ef706

📥 Commits

Reviewing files that changed from the base of the PR and between 6833a23 and 37fbbc6.

📒 Files selected for processing (1)
  • ci-operator/config/openstack-k8s-operators/lightspeed-operator/openstack-k8s-operators-lightspeed-operator-main.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openstack-k8s-operators/lightspeed-operator/openstack-k8s-operators-lightspeed-operator-main.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

Walkthrough

The OpenShift 4.20 CI configuration adds post-test gathering steps. It also increases the kuttl-test CPU and memory requests and memory limit.

Changes

CI diagnostics and resource allocation

Layer / File(s) Summary
Test diagnostics and resource allocation
ci-operator/config/openstack-k8s-operators/lightspeed-operator/openstack-k8s-operators-lightspeed-operator-main.yaml		 The configuration adds gather-extra and gather-must-gather post-test steps. The kuttl-test memory limit and request increase to 8 GiB. The CPU request increases to 1000m.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 37fbb

This localized resource configuration change has no actionable merge-blocking risk in the supplied evidence and is merge-ready after normal checks and review.

Suggested reviewers: psalajova, umago

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
No-Sensitive-Data-In-Logs ❌ Error The new post steps activate collectors that store all-namespace pod logs, audit logs, ConfigMaps, and Prometheus data; these may expose tokens, customer data, or internal hostnames, while sanitizat... Do not publish unfiltered gathered logs and cluster data. Add comprehensive redaction for secrets, tokens, PII, and hostnames, or remove the gather steps.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The HEAD^..HEAD diff contains only one YAML file: CI post-step references and kuttl-test resources; no Ginkgo test title changes or dynamic names were introduced.
Test Structure And Quality ✅ Passed The commit changes only one CI YAML file: resource values and post-gather steps. It adds no Ginkgo test source or It/Eventually/cleanup/assertion behavior.
Microshift Test Compatibility ✅ Passed The diff changes only CI YAML resources and post steps; it adds no Ginkgo e2e tests or MicroShift-incompatible API usage.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only CI YAML resources and post steps; it adds no Ginkgo e2e tests or multi-node assumptions covered by this check.
Topology-Aware Scheduling Compatibility ✅ Passed The PR changes only CI post steps and kuttl-test CPU/memory resources; it adds no deployment, operator, controller, or topology-dependent scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The commit changes only one CI YAML file: post-step refs and kuttl-test resources. It adds no OTE process code or stdout/logging writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only one CI YAML file. It adds post-gather steps and resource values, with no new Ginkgo tests, IPv4 assumptions, or external connectivity.
No-Weak-Crypto ✅ Passed The commit changes only CI post-step references and kuttl-test resource values; the parent and current YAML contain no MD5, SHA1, DES, RC4, Blowfish, ECB, or crypto implementation.
Container-Privileges ✅ Passed The diff only adds standard gather refs and increases kuttl-test resources; added lines contain no privileged, host*, SYS_ADMIN, securityContext, or allowPrivilegeEscalation settings.
Title check ✅ Passed The title clearly summarizes both primary changes: updating resources and adding must-gather post steps.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2026
@openshift-ci
openshift-ci Bot requested review from psalajova and umago August 19, 2026 09:55
@lpiwowar

lpiwowar commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

openshift-merge-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

@lpiwowar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@lpiwowar
lpiwowar marked this pull request as draft August 19, 2026 11:14
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2026
@lpiwowar
Update resources and add must-gather
37fbbc6 
Increase the src build's memory/CPU requests and limits, and collect
must-gather/extra artifacts on test completion.
@lpiwowar
lpiwowar force-pushed the lpiwowar/resources-fix branch from eddd444 to 37fbbc6 Compare August 21, 2026 14:59
@lpiwowar
lpiwowar marked this pull request as ready for review August 21, 2026 15:00
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2026
@lpiwowar lpiwowar changed the title Update resources for openstack-k8s-operators/lightspeed-operator Update resources and add must-gather Aug 21, 2026
@openshift-ci
openshift-ci Bot requested a review from bear-redhat August 21, 2026 15:00
@lpiwowar

lpiwowar commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

1 similar comment
@lpiwowar

lpiwowar commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

openshift-merge-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

@lpiwowar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

umago
umago approved these changes Aug 21, 2026
View reviewed changes

@umago umago left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2026
@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lpiwowar, umago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

@lpiwowar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openstack-k8s-operators/lightspeed-operator/main/openstack-lightspeed-kuttl-4-20 37fbbc6 link unknown /pj-rehearse pull-ci-openstack-k8s-operators-lightspeed-operator-main-openstack-lightspeed-kuttl-4-20

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lpiwowar

lpiwowar commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

openshift-merge-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

@lpiwowar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 21, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 17aeb86 into openshift:main Aug 21, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psalajova psalajova Awaiting requested review from psalajova
@bear-redhat bear-redhat Awaiting requested review from bear-redhat
1 more reviewer
@umago umago umago approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@umago umago

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lpiwowar @umago